Skip to content

Conversation

@keitakn
Copy link
Member

@keitakn keitakn commented Jun 19, 2018

Summary

resolved #52

IssueURL

#52

#52
resolve #52
@coveralls
Copy link

coveralls commented Jun 19, 2018

Pull Request Test Coverage Report for Build 109

  • 44 of 45 (97.78%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 99.495%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/PhpJsonLogger/MonologInstanceCreator.php 31 32 96.88%
Totals Coverage Status
Change from base Build 103: -0.5%
Covered Lines: 197
Relevant Lines: 198

💛 - Coveralls

@keitakn keitakn changed the title [WIP] Refactoring(#52) Refactoring(#52) Jun 19, 2018
@keitakn keitakn merged commit cb12b4e into master Jun 19, 2018
@keitakn keitakn deleted the feature/issue52 branch June 19, 2018 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

It should be re-design the class structure

3 participants