Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): cleanup go.mod a little bit #136

Merged
merged 3 commits into from Mar 6, 2020
Merged

Conversation

@chenrui333
Copy link
Contributor

chenrui333 commented Mar 6, 2020

No description provided.

@chenrui333 chenrui333 requested a review from cplee as a code owner Mar 6, 2020
go.mod Show resolved Hide resolved
@chenrui333

This comment has been minimized.

Copy link
Contributor Author

chenrui333 commented Mar 6, 2020

I will resolve the merging conflict now.

@chenrui333 chenrui333 force-pushed the chenrui333:update-go-mod branch from 3811c26 to 6435de5 Mar 6, 2020
@chenrui333

This comment has been minimized.

Copy link
Contributor Author

chenrui333 commented Mar 6, 2020

@cplee ready for review.

@cplee

This comment has been minimized.

Copy link
Contributor

cplee commented Mar 6, 2020

sorry @chenrui333 ...i made a mess by pushing an update on master 🤦‍♂️

I'll stop touching it, if you can fix this PR then i'll merge it

@chenrui333 chenrui333 force-pushed the chenrui333:update-go-mod branch from 8700a7b to c90f035 Mar 6, 2020
@chenrui333

This comment has been minimized.

Copy link
Contributor Author

chenrui333 commented Mar 6, 2020

No worries, I am fixing it now.

@chenrui333

This comment has been minimized.

Copy link
Contributor Author

chenrui333 commented Mar 6, 2020

Should be good now.

@cplee
cplee approved these changes Mar 6, 2020
@cplee cplee merged commit ca648a3 into nektos:master Mar 6, 2020
2 checks passed
2 checks passed
lint
Details
test
Details
@chenrui333

This comment has been minimized.

Copy link
Contributor Author

chenrui333 commented Mar 6, 2020

Appreciate your lightening fast merge! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.