Merged
Conversation
Contributor
|
@jnewland this is awesome! I'm very excited to add this...i'll review this week. |
Contributor
Author
|
@cplee right on no rush at all! 👍I'm happy to iterate on this PR in any way too: don't be shy with your review. 😄 |
cplee
requested changes
Feb 11, 2019
Contributor
cplee
left a comment
cplee
left a comment
There was a problem hiding this comment.
Looks good...couple minor changes please.
| for folderWatcher.IsRunning() { | ||
| for changes := range folderWatcher.ChangeDetails() { | ||
| log.Debugf("%s", changes.String()) | ||
| fn() |
Contributor
There was a problem hiding this comment.
the fn parameter for this watchAndRun function should be fn func() error and then use the return of that function to be the return for watchAndRun to avoid swallowing the error.
|
|
||
| // create the runner | ||
| runner, err := actions.NewRunner(runnerConfig) | ||
| err := parseAndRun(cmd, runnerConfig) |
Contributor
There was a problem hiding this comment.
how about moving this below as an else { } after the if watch {}?
makrsmark
pushed a commit
to makrsmark/act
that referenced
this pull request
Aug 3, 2023
- Replace `go-git` with a forked version in `go.mod` Signed-off-by: Bo-Yi.Wu <appleboy.tw@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-on: https://gitea.com/gitea/act/pulls/30 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Bo-Yi.Wu <appleboy.tw@gmail.com> Co-committed-by: Bo-Yi.Wu <appleboy.tw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for a
--watchor-wflag toact. When provided,actdoesn't exit after the first run, but instead runs a goroutine that watches the local directory for changes (ignoring files in.gitignore). When changes are detected, the workflow file is parsed and run again.A redux of #29, this time without conflicts.