Skip to content

Fix copyDir to normalize file paths in tar archive#360

Merged
cplee merged 1 commit intonektos:masterfrom
barweiss:bugfix/windows-tar-directory-structure
Sep 15, 2020
Merged

Fix copyDir to normalize file paths in tar archive#360
cplee merged 1 commit intonektos:masterfrom
barweiss:bugfix/windows-tar-directory-structure

Conversation

@barweiss
Copy link
Copy Markdown
Contributor

@barweiss barweiss commented Sep 7, 2020

@barweiss barweiss requested a review from cplee as a code owner September 7, 2020 12:59
@cplee
Copy link
Copy Markdown
Contributor

cplee commented Sep 14, 2020

@barweiss - seems like a simple change. can you help confirm the intention of this change? Are we looking to replace \ with / on windows hosts?

@barweiss
Copy link
Copy Markdown
Contributor Author

@barweiss - seems like a simple change. can you help confirm the intention of this change? Are we looking to replace \ with / on windows hosts?

Exactly, the files in the TAR archive end up having a backward slash in their names.

@cplee cplee merged commit 04456ad into nektos:master Sep 15, 2020
@barweiss barweiss deleted the bugfix/windows-tar-directory-structure branch November 8, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants