Merged
Conversation
added 7 commits
July 2, 2020 12:34
This uncovered that some of the test premisses was wrong and the Eval Bool function also had flaws
cplee
requested changes
Nov 10, 2020
Contributor
cplee
left a comment
cplee
left a comment
There was a problem hiding this comment.
looks great! one change requested...
| "encoding/hex" | ||
| "encoding/json" | ||
| "fmt" | ||
| "github.com/opencontainers/runc/Godeps/_workspace/src/github.com/Sirupsen/logrus" |
Contributor
Author
|
@cplee the stray logrus import is removed now. |
cplee
approved these changes
Nov 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered that table based tests must have define
assert := a.New(t)inside thet.Runinternal func.If not, the assert wasn't actually asserting correctly 🙈
This lead to the discovery of some test cases that wasn't actually working.
I had to make several changes to the EvalBool function support all the permutations of negations, envs and interpolations
Fixes #387