s/pull-request/pull_request#55
Merged
cplee merged 1 commit intonektos:masterfrom Apr 2, 2019
curiouslychase:master
Merged
Conversation
pull-request isn't an event type but pull_request is!
cplee
approved these changes
Apr 2, 2019
makrsmark
pushed a commit
to makrsmark/act
that referenced
this pull request
Aug 3, 2023
In [nektos/pull/1739](nektos#1739), the container network mode defaults to `host` if the network option isn't specified in `options`. When calling `ConnectToNetwork`, the `host` network mode may cause the error: `Error response from daemon: container sharing network namespace with another container or host cannot be connected to any other network` see the code: https://gitea.com/gitea/act/src/commit/a94a01bff2576fcf9fefaf879ea09c11e383cdab/pkg/container/docker_run.go#L51-L68 To avoid the error, this logic needs to be removed to keep the default network mode as `bridge`. Reviewed-on: https://gitea.com/gitea/act/pulls/55 Reviewed-by: Jason Song <i@wolfogre.com> Co-authored-by: Zettat123 <zettat123@gmail.com> Co-committed-by: Zettat123 <zettat123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this when trying to test an event: pull-request isn't an event type but pull_request is!