Skip to content

Add code testing on MacOS#563

Merged
cplee merged 2 commits intonektos:masterfrom
catthehacker:test-on-macos
Mar 29, 2021
Merged

Add code testing on MacOS#563
cplee merged 2 commits intonektos:masterfrom
catthehacker:test-on-macos

Conversation

@catthehacker
Copy link
Copy Markdown
Member

@catthehacker catthehacker commented Mar 12, 2021

Add code testing on MacOS. Performance is absolutely terrible on GHA (linux: <2 minutes, macos: >20 minutes) but hey! it works!

@catthehacker catthehacker requested a review from cplee as a code owner March 12, 2021 08:36
@cplee
Copy link
Copy Markdown
Contributor

cplee commented Mar 13, 2021

@catthehacker - is the slow part in the execution of the build or tests? Not sure I want to add a 20 min delay on each build 🤔

@catthehacker
Copy link
Copy Markdown
Member Author

catthehacker commented Mar 13, 2021

@cplee I know that MacOS runners on GitHub Actions have very bad performance especially with Docker running in VirtualBox machine, so I'm pretty sure that affects the testing phase and there shouldn't be any issue with building but I do not own any machine with MacOS so I can't tell how it looks like on normal Apple devices.
I'll try to get something up to verify it.

@catthehacker
Copy link
Copy Markdown
Member Author

catthehacker commented Mar 24, 2021

@cplee I couldn't find any way to test that myself locally yet. Would it be okay to merge PR if I remove dependency on MacOS test and add continue-on-error: true for MacOS?

@cplee cplee added the needs-work Extra attention is needed label Mar 29, 2021
@cplee
Copy link
Copy Markdown
Contributor

cplee commented Mar 29, 2021

@catthehacker - ready to merge once conflict is addressed.

@catthehacker
Copy link
Copy Markdown
Member Author

catthehacker commented Mar 29, 2021

@cplee Fixed conflicts and I've added continue-on-error: true to macos test as a failsafe so it doesn't break rest of workflow

@cplee
change name of test job
9a20a07 
Keep the test job named `test` to align with current branch protection checks
@cplee cplee merged commit f5a0258 into nektos:master Mar 29, 2021
@catthehacker catthehacker deleted the test-on-macos branch May 20, 2021 08:35
@catthehacker catthehacker removed the needs-work Extra attention is needed label Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cplee cplee cplee approved these changes

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@catthehacker @cplee