Skip to content

Return error if both run an uses are specified in one step#593

Merged
cplee merged 1 commit intonektos:masterfrom
catthehacker:warn-keys
Apr 1, 2021
Merged

Return error if both run an uses are specified in one step#593
cplee merged 1 commit intonektos:masterfrom
catthehacker:warn-keys

Conversation

@catthehacker
Copy link
Copy Markdown
Member

fix: return error if both run/uses keys are used
fixes #536

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2021

Codecov Report

Merging #593 (d8c1560) into master (5752a03) will increase coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
+ Coverage   47.80%   48.20%   +0.40%     
==========================================
  Files          23       23              
  Lines        2257     2261       +4     
==========================================
+ Hits         1079     1090      +11     
+ Misses       1062     1055       -7     
  Partials      116      116              
Impacted Files Coverage Δ
pkg/model/workflow.go 26.66% <100.00%> (+6.36%) ⬆️
pkg/runner/step_context.go 70.58% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5752a03...d8c1560. Read the comment docs.

@cplee cplee merged commit 25779af into nektos:master Apr 1, 2021
@catthehacker catthehacker deleted the warn-keys branch April 1, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

a step cannot be allowed have both the uses and run keys

2 participants