Refactor .actrc locations and default image survey#600
Merged
cplee merged 2 commits intonektos:masterfrom Apr 5, 2021
Merged
Conversation
added 2 commits
April 3, 2021 15:58
Moved actrc locations to own func since it can be reused. Moved survey part to own func due to high cyclomatic complexity. Added XDG config dir to config locations. Replaced using HOME envvar with go-homedir module since it's already an indirect dependency and handles home directories better for each GOOS.
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
==========================================
- Coverage 49.24% 49.20% -0.05%
==========================================
Files 23 23
Lines 2319 2321 +2
==========================================
Hits 1142 1142
- Misses 1051 1052 +1
- Partials 126 127 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #599
Moved actrc locations to own func since it can be reused.
Moved survey part to own func due to high cyclomatic complexity.
Added XDG config dir to config locations.
Replaced using HOME envvar with
go-homedirmodule since it's alreadyan indirect dependency and handles home directories better for each GOOS.