Skip to content

Fix: pwsh errors with "command not found"#649

Closed
JustinGrote wants to merge 1 commit intonektos:masterfrom
JustinGrote:JustinGrote/fixPowershellRun
Closed

Fix: pwsh errors with "command not found"#649
JustinGrote wants to merge 1 commit intonektos:masterfrom
JustinGrote:JustinGrote/fixPowershellRun

Conversation

@JustinGrote
Copy link
Copy Markdown
Contributor

pwsh includes the -login switch which causes the split to not work correctly. This fixes that issue.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@f56b21f). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #649   +/-   ##
=========================================
  Coverage          ?   49.31%           
=========================================
  Files             ?       23           
  Lines             ?     2322           
  Branches          ?        0           
=========================================
  Hits              ?     1145           
  Misses            ?     1050           
  Partials          ?      127           
Impacted Files Coverage Δ
pkg/runner/step_context.go 70.02% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f56b21f...31e692c. Read the comment docs.

@JustinGrote JustinGrote force-pushed the JustinGrote/fixPowershellRun branch from 5ea45d3 to 31e692c Compare May 1, 2021 19:17
@pull-request-size pull-request-size Bot added size/XS and removed size/M labels May 1, 2021
@catthehacker
Copy link
Copy Markdown
Member

I don't think we will merge this, I want to regress the -login/-l thing.

@JustinGrote
Copy link
Copy Markdown
Contributor Author

@catthehacker no prob, would you like a separate PR to remove the login switch?

@JustinGrote JustinGrote closed this May 1, 2021
@catthehacker
Copy link
Copy Markdown
Member

Currently I don't want to touch most of the codebase until other PRs get merged since there are few quite important fixes that should be in master first (643, 566, 635, 648...).
I want to see where we are after all that.

@JustinGrote JustinGrote deleted the JustinGrote/fixPowershellRun branch May 5, 2021 03:04
@catthehacker
Copy link
Copy Markdown
Member

@brian-pickens why? This PR is no longer needed

@brian-pickens
Copy link
Copy Markdown

I misunderstood the purpose of the PR initially, trying to troubleshoot my own issue. I'm thinking I need to use a more fully featured image to get access to powershell.

@catthehacker
Copy link
Copy Markdown
Member

You can use ghcr.io/catthehacker/ubuntu:pwsh-latest
https://github.com/catthehacker/docker_images/

@JustinGrote
Copy link
Copy Markdown
Contributor Author

I have images as well

ghcr.io/justingrote/act-pwsh:latest
ghcr.io/justingrote/act-pwsh-dotnet:latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants