WIP: Enable Non-Root Runner Scenarios#666
Conversation
|
@JustinGrote this pull request has failed checks 🛠 |
|
There is quite a mix of old code and different branches from your fork |
|
@catthehacker yeah as mentioned it's draft and WIP, I just rebased to my ActForWindows branch and haven't cleaned up the stuff that the merge missed. |
8c1c8e6 to
412e0c7
Compare
|
@JustinGrote this pull request has failed checks 🛠 |
2 similar comments
|
@JustinGrote this pull request has failed checks 🛠 |
|
@JustinGrote this pull request has failed checks 🛠 |
f517040 to
fd8f77c
Compare
|
@JustinGrote this pull request has failed checks 🛠 |
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
==========================================
+ Coverage 49.27% 50.11% +0.84%
==========================================
Files 23 23
Lines 2401 2542 +141
==========================================
+ Hits 1183 1274 +91
- Misses 1090 1132 +42
- Partials 128 136 +8
Continue to review full report at Codecov.
|
|
@JustinGrote this pull request has failed checks 🛠 |
bb8d0eb to
9db1599
Compare
|
Requesting design review and that you agree with the approach before I finish tests. |
9db1599 to
a0bbe3d
Compare
a0bbe3d to
42b0385
Compare
|
@JustinGrote this pull request is now in conflict 😩 |
|
PR is stale and will be closed in 14 days unless there is new activity |
Currently act requires the docker container to have root privileges to work because it both binds and mounts to the "same path" as the host.
While the bind method is useful if using act as a task runner, the mount method will fail in non-root containers.
In order to more accurately test Github Actions for both permission and pathing errors, this PR makes mounts use the runner workdir by default and sets permissions accordingly. Binds with the -b flag will be unaffected and will continue to use the same path as what is on the container.
It will also add a parameter to customize the starting container workdir separately from the host workdir, if there is such a situation where you dont' want to use the default (usually /home/runner/workdir)
Example that this will fix
Try a simple action that does
mkdir -p /my/random/path. This will work just fine in act, but fail in Github Actions, and you won't find out till you run it in github actions.