Skip to content

Fix environment variables and move envs.txt/event.json to fixed location#667

Merged
mergify[bot] merged 2 commits intonektos:masterfrom
catthehacker:cat/fix/environment-variables
May 5, 2021
Merged

Fix environment variables and move envs.txt/event.json to fixed location#667
mergify[bot] merged 2 commits intonektos:masterfrom
catthehacker:cat/fix/environment-variables

Conversation

@catthehacker
Copy link
Copy Markdown
Member

@catthehacker catthehacker commented May 5, 2021

fix: move envs.txt & event.json to /tmp/workflow/

Since #635 envs.txt is not copying properly when running act in WSL2 (Linux <> Linux) (didn't tried it with Windows <> Linux scenario)
Moving it to fixed location resolves that as it doesn't need to move around since we have GITHUB_ENV
fix: environment variables sourcing from /etc/environment

hackercat added 2 commits May 5, 2021 21:20
Since nektos#635 `envs.txt` is not copying properly when running `act` in WSL2
Moving it to fixed location resolves that.
@catthehacker catthehacker requested a review from a team as a code owner May 5, 2021 22:24
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2021

Codecov Report

Merging #667 (2ba5489) into master (0f04942) will increase coverage by 0.50%.
The diff coverage is 51.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
+ Coverage   49.27%   49.77%   +0.50%     
==========================================
  Files          23       23              
  Lines        2401     2469      +68     
==========================================
+ Hits         1183     1229      +46     
- Misses       1090     1104      +14     
- Partials      128      136       +8     
Impacted Files Coverage Δ
pkg/container/docker_run.go 1.91% <0.00%> (-0.02%) ⬇️
pkg/runner/runner.go 76.47% <ø> (ø)
pkg/common/git.go 55.50% <20.00%> (-4.30%) ⬇️
pkg/model/workflow.go 30.71% <33.33%> (+5.00%) ⬆️
pkg/model/planner.go 34.56% <41.37%> (+1.48%) ⬆️
pkg/container/docker_pull.go 36.17% <64.70%> (+17.98%) ⬆️
pkg/runner/step_context.go 71.42% <84.61%> (+2.48%) ⬆️
pkg/runner/run_context.go 76.60% <93.33%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aba4fec...2ba5489. Read the comment docs.

@mergify mergify Bot merged commit 8153dc9 into nektos:master May 5, 2021
@catthehacker catthehacker linked an issue May 6, 2021 that may be closed by this pull request
KnisterPeter pushed a commit to xing/act that referenced this pull request May 6, 2021
@catthehacker catthehacker deleted the cat/fix/environment-variables branch August 11, 2021 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue: Environment variable USER is not set

3 participants