Merged
Conversation
added 2 commits
May 12, 2021 12:17
* remove all references to `gotest.tools` and replace it with `github.com/stretchr/testify` which was originally used for tests * bump `golangci-lint` version * add `depguard` and `importas` to prevent import of unwanted packages * add custom schema and information about config since schemastore.org has broken schema for `golangci-lint` config
Codecov Report
@@ Coverage Diff @@
## master #688 +/- ##
==========================================
+ Coverage 49.27% 50.51% +1.24%
==========================================
Files 23 23
Lines 2401 2532 +131
==========================================
+ Hits 1183 1279 +96
- Misses 1090 1114 +24
- Partials 128 139 +11
Continue to review full report at Codecov.
|
cplee
approved these changes
May 18, 2021
Contributor
|
@catthehacker this pull request has failed checks 🛠 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gotest.toolsand replace it withgithub.com/stretchr/testifywhich was originally used for testsgolangci-lintversiondepguardandimportasto prevent import of unwanted packagesschemastore.org has broken schema for
golangci-lintconfig