Fix format function {{, }} are escapes#752
Merged
mergify[bot] merged 2 commits intonektos:masterfrom Aug 9, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #752 +/- ##
==========================================
+ Coverage 49.27% 50.79% +1.52%
==========================================
Files 23 23
Lines 2401 2644 +243
==========================================
+ Hits 1183 1343 +160
- Misses 1090 1158 +68
- Partials 128 143 +15
Continue to review full report at Codecov.
|
4a643d7 to
fcc4e7c
Compare
This comment has been minimized.
This comment has been minimized.
Added some tests for some corner cases
fcc4e7c to
cd7ed35
Compare
Member
correct |
catthehacker
approved these changes
Aug 9, 2021
cplee
approved these changes
Aug 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github transforms multiple expressions into one format expression while parsing and every non expression
{is replaced by{{and}by}}.I assume vmformat should mimic githubs behavior, issues appeard during testing of https://github.com/ChristopherHX/github-actions-act-runner.
Haven't searched any documentation about this yet.
Some corner cases fixed too
format('{0}', github.undefined_value)should be an empty string notundefined.format('{0}', '{1}', 'Hello')should be{1}notHello.How do I test the error handler?
vmFormat has no error output, so the tests cannot test for error messages or did I miss something?