Skip to content

Fix docker: invalid reference format#767

Merged
mergify[bot] merged 9 commits intonektos:masterfrom
ChristopherHX:fix/invalid-reference-format
Aug 9, 2021
Merged

Fix docker: invalid reference format#767
mergify[bot] merged 9 commits intonektos:masterfrom
ChristopherHX:fix/invalid-reference-format

Conversation

@ChristopherHX
Copy link
Copy Markdown
Contributor

Added a test to enshure that docker actions with names ending by anything which matches against [^a-zA-Z0-9] will still generate a valid docker container name.

./test_ would get image name like act-test-:latest => docker fails without this change

Fixes #744
Fixes #756

@ChristopherHX ChristopherHX requested a review from a team as a code owner August 8, 2021 10:18
@mergify

This comment has been minimized.

@mergify mergify Bot added the needs-work Extra attention is needed label Aug 8, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 8, 2021

Codecov Report

Merging #767 (079c8ae) into master (0f04942) will increase coverage by 4.79%.
The diff coverage is 64.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #767      +/-   ##
==========================================
+ Coverage   49.27%   54.06%   +4.79%     
==========================================
  Files          23       23              
  Lines        2401     2658     +257     
==========================================
+ Hits         1183     1437     +254     
+ Misses       1090     1074      -16     
- Partials      128      147      +19     
Impacted Files Coverage Δ
pkg/container/docker_build.go 0.00% <0.00%> (ø)
pkg/container/docker_run.go 1.83% <0.00%> (-0.10%) ⬇️
pkg/common/git.go 52.85% <30.15%> (-6.94%) ⬇️
pkg/runner/runner.go 68.96% <33.33%> (-7.51%) ⬇️
pkg/model/planner.go 51.85% <41.37%> (+18.76%) ⬆️
pkg/model/workflow.go 51.08% <62.68%> (+25.37%) ⬆️
pkg/container/docker_pull.go 36.17% <64.70%> (+17.98%) ⬆️
pkg/runner/expression.go 85.38% <71.87%> (-1.26%) ⬇️
pkg/runner/step_context.go 78.37% <79.03%> (+9.43%) ⬆️
pkg/runner/run_context.go 80.36% <98.55%> (+3.95%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c841e2...079c8ae. Read the comment docs.

@mergify mergify Bot removed the needs-work Extra attention is needed label Aug 8, 2021
ubuntu:latest would pull unnecessary blobs from registry and count toward API limit
catthehacker
catthehacker previously approved these changes Aug 9, 2021
@mergify

This comment has been minimized.

@mergify mergify Bot added the needs-work Extra attention is needed label Aug 9, 2021
Ryan added 2 commits August 9, 2021 19:43
reverting due to issue in image deletion that will have to be investigated separately
@mergify mergify Bot removed the needs-work Extra attention is needed label Aug 9, 2021
@mergify mergify Bot requested a review from a team August 9, 2021 17:56
@mergify mergify Bot requested a review from a team August 9, 2021 18:01
@mergify mergify Bot merged commit 77b3968 into nektos:master Aug 9, 2021
@ChristopherHX ChristopherHX deleted the fix/invalid-reference-format branch August 9, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue: Local actions not working. Issue: act failed to build docker image

3 participants