Fix docker: invalid reference format#767
Merged
mergify[bot] merged 9 commits intonektos:masterfrom Aug 9, 2021
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #767 +/- ##
==========================================
+ Coverage 49.27% 54.06% +4.79%
==========================================
Files 23 23
Lines 2401 2658 +257
==========================================
+ Hits 1183 1437 +254
+ Misses 1090 1074 -16
- Partials 128 147 +19
Continue to review full report at Codecov.
|
ubuntu:latest would pull unnecessary blobs from registry and count toward API limit
catthehacker
previously approved these changes
Aug 9, 2021
This comment has been minimized.
This comment has been minimized.
added 2 commits
August 9, 2021 19:43
reverting due to issue in image deletion that will have to be investigated separately
catthehacker
approved these changes
Aug 9, 2021
cplee
approved these changes
Aug 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a test to enshure that docker actions with names ending by anything which matches against
[^a-zA-Z0-9]will still generate a valid docker container name../test_would get image name likeact-test-:latest=> docker fails without this changeFixes #744
Fixes #756