Cache dockerhub images from linux for macOS#768
Merged
cplee merged 5 commits intonektos:masterfrom Aug 31, 2021
Merged
Conversation
An attempt to avoid hitting the dockerhub Pull Rate Limit.
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
==========================================
+ Coverage 49.27% 53.92% +4.65%
==========================================
Files 23 23
Lines 2401 2674 +273
==========================================
+ Hits 1183 1442 +259
+ Misses 1090 1086 -4
- Partials 128 146 +18
Continue to review full report at Codecov.
|
catthehacker
previously approved these changes
Aug 11, 2021
Member
catthehacker
left a comment
There was a problem hiding this comment.
My plans are to escape DockerHub and move everything to other registries but this will suffice for now.
cplee
previously approved these changes
Aug 12, 2021
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
This PR doesn't need work, it only needs to be merged manually |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cplee
approved these changes
Aug 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to avoid hitting the dockerhub Pull Rate Limit.
There is a small overhead due to caching (ca. +2 min, next run within 7 days only some seconds), but it might avoid rerunning the macOS job due to this error.
Restoreing the cache doesn't take much extra job execution time, because the test step is pulling less images from dockerhub.
This PR failed due to this limit #776.
It seems to be triggered by multiple PR's are opened within some days.
Needs more testing, if this solves the dockerhub limit problems or only delays the problem to happen less frequently.
Add new dockerhub images to
CACHED_DOCKER_IMAGESand increment the cache key (CACHED_DOCKER_IMAGES_KEY)What do you think?
I need ACT_OWNER: ${{ github.repository_owner }} and ACT_REPOSITORY: ${{ github.repository }} to have all tests green within my fork