Skip to content

WIP: expr parser parity#792

Closed
ChristopherHX wants to merge 7 commits intonektos:masterfrom
ChristopherHX:feature/expr-parser-parity
Closed

WIP: expr parser parity#792
ChristopherHX wants to merge 7 commits intonektos:masterfrom
ChristopherHX:feature/expr-parser-parity

Conversation

@ChristopherHX
Copy link
Copy Markdown
Contributor

@ChristopherHX ChristopherHX commented Aug 30, 2021

Currently the expression parser is a bit to far away from githubs one this breaks my github-act-runner program.
This PR will

  • reject some js only syntax.
  • format will throw js exceptions on errors
  • fromjson will parse non object types like arrays, numbers, strings
  • secrets will work in more complex expressions, with toUpperCase in brackets
  • allow to use the .*. syntax of github actions, will be rewritten via map

Resolves #718

Well might be really stale now

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Aug 30, 2021

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify Bot added the needs-work Extra attention is needed label Aug 30, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 30, 2021

Codecov Report

Merging #792 (85880a8) into master (0f04942) will increase coverage by 6.67%.
The diff coverage is 60.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #792      +/-   ##
==========================================
+ Coverage   49.27%   55.94%   +6.67%     
==========================================
  Files          23       23              
  Lines        2401     3875    +1474     
==========================================
+ Hits         1183     2168     +985     
- Misses       1090     1515     +425     
- Partials      128      192      +64     
Impacted Files Coverage Δ
pkg/container/docker_run.go 5.63% <16.16%> (+3.70%) ⬆️
pkg/common/git.go 49.82% <31.81%> (-9.97%) ⬇️
pkg/model/planner.go 49.78% <42.50%> (+16.70%) ⬆️
pkg/container/docker_build.go 59.72% <50.00%> (+59.72%) ⬆️
pkg/runner/expression.go 73.25% <59.45%> (-13.39%) ⬇️
pkg/model/workflow.go 52.14% <63.63%> (+26.42%) ⬆️
pkg/container/docker_pull.go 36.36% <64.00%> (+18.18%) ⬆️
pkg/runner/runner.go 74.46% <70.37%> (-2.01%) ⬇️
pkg/runner/step_context.go 78.57% <77.06%> (+9.62%) ⬆️
pkg/runner/run_context.go 83.54% <91.17%> (+7.14%) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d3602...85880a8. Read the comment docs.

@mergify mergify Bot removed the needs-work Extra attention is needed label Aug 30, 2021
@github-actions
Copy link
Copy Markdown
Contributor

PR is stale and will be closed in 14 days unless there is new activity

@github-actions github-actions Bot added the stale label Sep 30, 2021
@github-actions github-actions Bot closed this Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue: act allows ternary operator in expression

1 participant