Skip to content

refactor: re-implement embed without "unused" import#830

Merged
mergify[bot] merged 2 commits intonektos:masterfrom
catthehacker:cat/refactor/trampoline
Sep 27, 2021
Merged

refactor: re-implement embed without "unused" import#830
mergify[bot] merged 2 commits intonektos:masterfrom
catthehacker:cat/refactor/trampoline

Conversation

@catthehacker
Copy link
Copy Markdown
Member

Code clean-up

@catthehacker catthehacker requested a review from a team as a code owner September 27, 2021 17:13
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 27, 2021

Codecov Report

Merging #830 (1d4cf7e) into master (0f04942) will increase coverage by 5.30%.
The diff coverage is 62.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #830      +/-   ##
==========================================
+ Coverage   49.27%   54.57%   +5.30%     
==========================================
  Files          23       23              
  Lines        2401     3729    +1328     
==========================================
+ Hits         1183     2035     +852     
- Misses       1090     1540     +450     
- Partials      128      154      +26     
Impacted Files Coverage Δ
pkg/container/docker_build.go 0.00% <0.00%> (ø)
pkg/container/docker_run.go 6.67% <21.35%> (+4.75%) ⬆️
pkg/common/git.go 49.82% <31.81%> (-9.97%) ⬇️
pkg/model/planner.go 49.78% <42.50%> (+16.70%) ⬆️
pkg/model/workflow.go 52.14% <63.63%> (+26.42%) ⬆️
pkg/container/docker_pull.go 36.36% <64.00%> (+18.18%) ⬆️
pkg/runner/runner.go 74.46% <70.37%> (-2.01%) ⬇️
pkg/runner/expression.go 85.71% <72.09%> (-0.93%) ⬇️
pkg/runner/step_context.go 78.93% <77.60%> (+9.99%) ⬆️
pkg/runner/run_context.go 81.85% <91.08%> (+5.44%) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfcf0ab...1d4cf7e. Read the comment docs.

cplee
cplee previously approved these changes Sep 27, 2021
@mergify mergify Bot merged commit 7a426a0 into nektos:master Sep 27, 2021
@catthehacker catthehacker deleted the cat/refactor/trampoline branch September 27, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants