Skip to content

feat: print plan summary upfront to executing it#913

Closed
KnisterPeter wants to merge 1 commit intonektos:masterfrom
KnisterPeter:print-plan
Closed

feat: print plan summary upfront to executing it#913
KnisterPeter wants to merge 1 commit intonektos:masterfrom
KnisterPeter:print-plan

Conversation

@KnisterPeter
Copy link
Copy Markdown
Member

This change will print a toc at debug level upfront to running a workflow. It will help prepare outputs for (e.g. UI) before executing and parsing the log output.

We would like to add this to the output of act, since we are parsing the output with a computer to create a more meaningful output in a website for it. The log boundaries are created to be easily machine parsable.

@KnisterPeter KnisterPeter requested a review from a team as a code owner December 3, 2021 10:12
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 3, 2021

Codecov Report

Merging #913 (b4c7b13) into master (0f04942) will increase coverage by 6.98%.
The diff coverage is 60.36%.

❗ Current head b4c7b13 differs from pull request most recent head adc1810. Consider uploading reports for the commit adc1810 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #913      +/-   ##
==========================================
+ Coverage   49.27%   56.25%   +6.98%     
==========================================
  Files          23       28       +5     
  Lines        2401     4083    +1682     
==========================================
+ Hits         1183     2297    +1114     
- Misses       1090     1579     +489     
- Partials      128      207      +79     
Impacted Files Coverage Δ
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/common/testflag.go 0.00% <0.00%> (ø)
pkg/container/docker_volume.go 0.00% <0.00%> (ø)
pkg/model/action.go 0.00% <ø> (ø)
pkg/container/docker_run.go 5.53% <14.54%> (+3.60%) ⬆️
pkg/common/git.go 49.82% <31.81%> (-9.97%) ⬇️
pkg/runner/logger.go 65.43% <37.50%> (+1.28%) ⬆️
pkg/model/planner.go 49.78% <42.50%> (+16.70%) ⬆️
pkg/container/docker_auth.go 45.00% <45.00%> (ø)
pkg/container/docker_build.go 58.97% <50.00%> (+58.97%) ⬆️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b910a42...adc1810. Read the comment docs.

@catthehacker
Copy link
Copy Markdown
Member

I would like to not have that, since it's visual noise and doesn't help act

@KnisterPeter
Copy link
Copy Markdown
Member Author

Okay, we will then keep in on our side.
I'll close the PR as soon as I've moved into our Org.

This change will print a toc at debug level upfront to running
a workflow. It will help prepare outputs for (e.g. UI) before
executing and parsing the log output.

Co-authored-by: Philipp Hinrichsen <philipp.hinrichsen@new-work.se>
@KnisterPeter KnisterPeter deleted the print-plan branch December 6, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants