fix(website): hero CTA always goes to the download page#56
Merged
Conversation
The hero "Download for free" button had its href rewritten on load by a userAgent sniff in script.js, which forced a direct platform download (Windows .exe / macOS .zip / Linux .tar.gz). This was misleading because: - The app is multi-platform; we now also ship on the Microsoft Store (the most appropriate Windows install path), not just GitHub Releases. - The macOS branch still pointed at PDFApps-macOS.zip, which no longer exists — we ship a .dmg as of v1.13.4. - Forcing a download bypasses the dedicated download page where users can see all install options (Store, .exe, DMG, Snap, Copr, AUR, AppImage, ...). Removing the override lets the HTML href="download.html" take effect on every platform, surfacing the curated install options instead of guessing the user's OS. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The hero "Download for free" button on the homepage was being rewritten by a userAgent sniff in `script.js` to point directly at a platform-specific asset on GitHub Releases. This stopped making sense now that PDFApps is multi-platform and on the Microsoft Store — and the macOS branch was also pointing at the obsolete `PDFApps-macOS.zip` (replaced by `.dmg` in v1.13.4).
Fix
Remove the OS-detecting block in `script.js` so the HTML `href="download.html"` takes effect on every platform. Users now land on the download page where the Microsoft Store badge, .exe installer, macOS DMG and Linux packages are all surfaced explicitly.
Test plan
🤖 Generated with Claude Code