Merged
Conversation
… are explicitly specified as going to stdout in README.md.
dcoraboeuf
approved these changes
Jun 15, 2018
Contributor
|
Available in 2.7.1 |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've put together a pull request for switching the plugin output to use a
Loggerrather thanprintlndirectly because it gives users of the plugin more control over how much output they see.The only output I haven't touched is that from
VersionDisplayTaskbecause the point of the task is to output tostdout. As it turns out, that actually means I've only changed two classes: the dirty warning inVersioningExtensionand various places inSVNInfoService; the Subversion side of the plugin seems to be much more vocal than the Git side.Personally, I prefer my builds to be mute as far as possible unless something fails, because I find this helps prevent the important output being lost in a sea of text. Other people prefer a more verbose build. The
Loggergives us the best of both worlds.Lastly, I've included a second commit with the non-functional code cleanup my IDE suggested in the files I modified. I don't know what your preferences are on that front, so I wanted to make it easy to exclude those changes if you want to.