Skip to content

Use Logger for output#48

Merged
dcoraboeuf merged 2 commits intonemerosa:masterfrom
markslater:use-logger-for-output
Jun 15, 2018
Merged

Use Logger for output#48
dcoraboeuf merged 2 commits intonemerosa:masterfrom
markslater:use-logger-for-output

Conversation

@markslater
Copy link
Contributor

Hi,

I've put together a pull request for switching the plugin output to use a Logger rather than println directly because it gives users of the plugin more control over how much output they see.

The only output I haven't touched is that from VersionDisplayTask because the point of the task is to output to stdout. As it turns out, that actually means I've only changed two classes: the dirty warning in VersioningExtension and various places in SVNInfoService; the Subversion side of the plugin seems to be much more vocal than the Git side.

Personally, I prefer my builds to be mute as far as possible unless something fails, because I find this helps prevent the important output being lost in a sea of text. Other people prefer a more verbose build. The Logger gives us the best of both worlds.

Lastly, I've included a second commit with the non-functional code cleanup my IDE suggested in the files I modified. I don't know what your preferences are on that front, so I wanted to make it easy to exclude those changes if you want to.

@dcoraboeuf dcoraboeuf merged commit 56bdd2e into nemerosa:master Jun 15, 2018
@dcoraboeuf
Copy link
Contributor

Available in 2.7.1

@markslater
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants