Skip to content

FIX SQRT #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erikzhang merged 7 commits into from
Jul 15, 2021
Merged

FIX SQRT #427

erikzhang merged 7 commits into from
Jul 15, 2021

Conversation

@vang1ong7ang
Copy link
Contributor

@vang1ong7ang vang1ong7ang commented Jul 14, 2021 •
edited
Loading

#421 Related

@vang1ong7ang vang1ong7ang mentioned this pull request Jul 14, 2021
Merged
@vang1ong7ang
Copy link
Contributor Author

vang1ong7ang commented Jul 14, 2021

@superboyiii @ProDog please help to test this PR to ensure the correctness.

@ProDog
Copy link

ProDog commented Jul 14, 2021

It's cheaper, but 4's sqrt is not right👀.

neo> invoke 0x01a8623d4d7afac0472f629d5a7c521e00e3149d sqrt [{"type":"Integer","value":"4"}]
Invoking script with: 'FBHAHwwEc3FydAwUnRTjAB5SfFqdYi9HwPp6TT1iqAFBYn1bUg=='
VM State: HALT
Gas Consumed: 0.0105069
Result Stack: [{"type":"Integer","value":"4"}]
Network fee: 0.0118058
Total fee: 0.0223127 GAS
Relay tx? (no|yes):

@vang1ong7ang
Copy link
Contributor Author

vang1ong7ang commented Jul 14, 2021

@ProDog coooool you got it.

already fixed

@shargon
Copy link
Member

shargon commented Jul 14, 2021

@vang1ong7ang could you give me edit rights?

@vang1ong7ang
Copy link
Contributor Author

vang1ong7ang commented Jul 14, 2021

@shargon Sure, and i have added it to you

ProDog
ProDog approved these changes Jul 14, 2021
View reviewed changes
Copy link

@ProDog ProDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TESTED OK.

@shargon
Copy link
Member

shargon commented Jul 14, 2021

@shargon Sure, and i have added it to you

I can't...

@superboyiii superboyiii mentioned this pull request Jul 14, 2021
Closed
24 tasks
@vang1ong7ang
Copy link
Contributor Author

vang1ong7ang commented Jul 14, 2021

@shargon check https://github.com/neo-ngd/neo-vm/invitations see if it works, if not, feel free to create new PR and close this one or edit the branch of this PR.

@vang1ong7ang vang1ong7ang requested a review from ProDog July 14, 2021 10:13
ProDog
ProDog previously approved these changes Jul 14, 2021
View reviewed changes
@shargon
Copy link
Member

shargon commented Jul 14, 2021

@vang1ong7ang there are no invitations, please check the PR

@vang1ong7ang
Copy link
Contributor Author

vang1ong7ang commented Jul 14, 2021

@shargon sorry i invited shagon instead of shargon before 🤒 . now it should work

@superboyiii
Copy link
Member

superboyiii commented Jul 15, 2021

@erikzhang Merge?

@erikzhang erikzhang merged commit d12fe8f into neo-project:master Jul 15, 2021
@shargon shargon deleted the vang1ong7ang-patch-1 branch July 15, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shargon shargon shargon approved these changes

+1 more reviewer

@ProDog ProDog ProDog left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vang1ong7ang @ProDog @shargon @superboyiii @erikzhang