This repository was archived by the owner on Apr 22, 2020. It is now read-only.
Similarity Function Examples #804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneedham
force-pushed
the
pearson-functions-docs
branch
from
9b4af48 to
a1fae46
Compare
mneedham
force-pushed
the
pearson-functions-docs
branch
from
169bd1f to
9492a83
Compare
mneedham
changed the title
Contributor
Author
|
@davidoliverSP2 figured I may as well add similar examples for the other similarity functions at the same time as for Pearson |
davidoliverSP2
approved these changes
Feb 4, 2019
Collaborator
davidoliverSP2
left a comment
davidoliverSP2
left a comment
There was a problem hiding this comment.
Thanks @mneedham
Looks good - a couple of small things I noticed on the Pearson algo (comments inline)
👍
doc/asciidoc/similarity-pearson.adoc
Outdated
| // end::function-cypher[] | ||
|
|
||
|
|
||
| In this example we pass in `vectorType: "maps"` as an extra parameter, as well as using the `algo.similarity.asVector` function to construct a vector of maps containing each movie and the corresponding rating. |
Collaborator
There was a problem hiding this comment.
missing comma.....
In this example, .....
doc/asciidoc/similarity-pearson.adoc
Outdated
|
|
||
|
|
||
| In this example we pass in `vectorType: "maps"` as an extra parameter, as well as using the `algo.similarity.asVector` function to construct a vector of maps containing each movie and the corresponding rating. | ||
| We do this because the Pearson similarity algorithm needs to compute the average of *all* the movies that a user has reviewed, not just the ones that they have in common with the user we're comparing them to. |
Collaborator
There was a problem hiding this comment.
Algo name should be capitalised as per the header: Pearson Similarity algorithm
mneedham
added a commit
that referenced
this pull request
Feb 4, 2019
* explaining how to use pearson function * update result * Add cosine function example * typo * jaccard examples * update jaccard examples * euclidean + better explanatory text on the others * address david's feedback
Contributor
Author
|
@davidoliverSP2 cool! T'is merged in now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.