Skip to content

Conversation

@lidiazuin
Copy link
Collaborator

No description provided.

@lidiazuin lidiazuin requested a review from recrwplay April 24, 2024 11:12
@netlify
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for neo4j-docs-ui ready!

Name Link
🔨 Latest commit 3ab192f
🔍 Latest deploy log https://app.netlify.com/sites/neo4j-docs-ui/deploys/663357029a46de00086677e9
😎 Deploy Preview https://deploy-preview-225--neo4j-docs-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@davidoliverSP2
Copy link
Contributor

Thanks @lidiazuin - I think the dropdown is also missing the new Query API, could we add it in this PR?
Check with @stefano-ottolenghi to see where in the list he thinks it should go!

<span class="project-name">Neo4j Graph Data Science</span>
<ul class="project-links">
<li><a href="/docs/graph-data-science/current/" class="project-link">Neo4j Graph Data Science Library</a></li>
<li><a href="/docs/graph-data-science-client/current/" class="project-link">Neo4j Graph Data Science Client</a></li>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent this as the previous <li> element.

- name: Sync UI Bundle to S3
run: |
aws s3 sync --follow-symlinks --include '*.zip' --no-progress build s3://${{ secrets.STATIC_CONTENT_BUCKET }}/build
aws s3 sync --follow-symlinks --include '*.zip' --no-progress build s3://${{ secrets.STATIC_CONTENT_BUCKET }}/build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove changes to both workflow files from this PR, as they don't belong. It's good hygiene and will help any future troubleshooting involving those files.

<li><a href="/docs/ogm-manual/current/" class="project-link">OGM Library</a></li>
<li><a href="https://docs.spring.io/spring-data/neo4j/docs/current/reference/html/#reference" class="project-link">Spring Data Neo4j</a></li>
<li><a href="/docs/http-api/current/" class="project-link">HTTP API</a></li>
<li><a href="/docs/query-api" class="project-link">Neo4j Query API</a></li>
Copy link
Collaborator

@stefano-ottolenghi stefano-ottolenghi Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All versioned docsets should have links pointing to /current, to avoid a redirect. It applies to Query API and Dataflow templates, but there may be more to fix in this file.

@MarkWoulfeNeo4j MarkWoulfeNeo4j self-requested a review May 7, 2024 09:59
Copy link
Collaborator

@MarkWoulfeNeo4j MarkWoulfeNeo4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidiazuin lidiazuin merged commit 3a50ebb into neo4j-documentation:master May 7, 2024
@lidiazuin lidiazuin deleted the gdsclient branch May 7, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants