Fix bug in label parsing #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for neo4j-docs-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stefano-ottolenghi
approved these changes
Jun 3, 2024
Collaborator
stefano-ottolenghi
left a comment
stefano-ottolenghi
left a comment
There was a problem hiding this comment.
Haven't tested, but code-wise and aparte the linting warnings LGTM.
src/js/60-docs-roles.js
Outdated
|
|
||
| roleDivs.forEach(function (roleDiv) { | ||
| var roles = roleDiv.classList | ||
| // ignore discrete headers |
Collaborator
There was a problem hiding this comment.
I'd move the comment to before line 76, where the check happens.
Collaborator
Author
There was a problem hiding this comment.
Argh - well spotted. I actually meant to combine the if statements before committing
Collaborator
Author
Thanks - I also fixed the linting warnings with the later commit |
recrwplay
added a commit
that referenced
this pull request
Jun 3, 2024
Fixes an issue with some labels being wrongly parsed where the text before the first hyphen was used instead of the full label. For example, `aura-db-enterprise` was being treated as `aura` because that is a valid label in rolesData.json. There are essentially two types of labels: - 'version' labels, where we want to use only the text before the hyphen, eg `new-5.20` for the label class and add the text after the hyphen as label text. - all other labels, where we take the whole label text and use that for the label class, and take the label text from rolesData.json This PR also fixes an issue with discrete headings. Labels are no longer displayed on discrete headings.
recrwplay
added a commit
to recrwplay/docs-ui
that referenced
this pull request
Jul 22, 2024
Fixes an issue with some labels being wrongly parsed where the text before the first hyphen was used instead of the full label. For example, `aura-db-enterprise` was being treated as `aura` because that is a valid label in rolesData.json. There are essentially two types of labels: - 'version' labels, where we want to use only the text before the hyphen, eg `new-5.20` for the label class and add the text after the hyphen as label text. - all other labels, where we take the whole label text and use that for the label class, and take the label text from rolesData.json This PR also fixes an issue with discrete headings. Labels are no longer displayed on discrete headings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with some labels being wrongly parsed where the text before the first hyphen was used instead of the full label.
For example,
aura-db-enterprisewas being treated asaurabecause that is a valid label in rolesData.json.There are essentially two types of labels:
new-5.20for the label class and add the text after the hyphen as label text.This PR also fixes an issue with discrete headings.
Labels are no longer displayed on discrete headings.