Skip to content

Conversation

@adam-cowley
Copy link
Collaborator

No description provided.

@adam-cowley adam-cowley requested a review from recrwplay June 11, 2024 14:33
@netlify
Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for neo4j-docs-ui ready!

Name Link
🔨 Latest commit e79782f
🔍 Latest deploy log https://app.netlify.com/sites/neo4j-docs-ui/deploys/666961c2513e6200085e0c0a
😎 Deploy Preview https://deploy-preview-234--neo4j-docs-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@recrwplay
Copy link
Collaborator

Looks good to me. The cleanest way I can find to add sidebar and promos to pages is:

  • Set an attribute in a playbook for courses path in github: ga-courses-uri: https://raw.githubusercontent.com/neo4j-graphacademy/courses/main/asciidoc/courses
  • Set a header attribute on the page for the course to link to: :ga-course: app-go
  • Add the sidebar ad by adding header attribute: include::{ga-courses-uri}/{ga-course}/ad.adoc[]
  • Add a promo to the end of the page: include::{ga-courses-uri}/{ga-course}/promo.adoc[]

Possibly overkill to set the ga-course attribute (in this case it means typing more characters) but a header attribute could be accessed by a script, which might have future value.

@adam-cowley
Copy link
Collaborator Author

Sounds good. I'm not sure if the ad.adoc file will be much use for manual-wide config in antora.yml but at least there's a reference for copy & paste

@adam-cowley adam-cowley merged commit 51f4b07 into master Jun 12, 2024
@adam-cowley adam-cowley deleted the graphacademy-promos branch June 12, 2024 10:33
recrwplay pushed a commit to recrwplay/docs-ui that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants