Making all card styles clickable #298
Conversation
✅ Deploy Preview for neo4j-docs-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/css/docs-ndl.css
Outdated
| line-height: 2rem; | ||
| } | ||
|
|
||
| body.docs-ndl .cards .sect2:hover, |
There was a problem hiding this comment.
@recrwplay I only managed to fix the hover effect, but not the a state to make [.cards] without .selectable or .not-selectable to become clickable. Could you help me, please? :))
There was a problem hiding this comment.
Cards can be displayed in two ways:
- Selectable - the first link in
[.links]on this card is wrapped round the card contents. The whole card becomes a link. No links are displayed on the card - All other cards - The card itself is not selectable. The links in
[.links]are displayed on the card.
A card becomes selectable if it has [.selectable] applied, or if it's in a section that has that role.
It sounds like you want to make all cards clickable, including cards that display a link. What happens when there is more than one link on a card?
| Choose from self-managed local and cloud deployments, or fully-managed options. | ||
|
|
||
| [.link] | ||
| [.link.display] |
There was a problem hiding this comment.
@MarkWoulfeNeo4j if we merge this change, then you'll need to update GTM with this new subclass of links in cards in the homepage, I think
recrwplay
left a comment
recrwplay
left a comment
There was a problem hiding this comment.
This seems to achieve the desired behavior.
I do have a small issue with cards in general now - we now have cards that look the same but behave differently (some cards that display a link are also selectable, for some it's only the displayed link that is selectable), and cards that look different but behave the same (some selectable cards display a link, some don't). I'd rather we didn't, but I don't want to make it a blocker to this PR.
2 participants
No description provided.