Skip to content

Fix layout, styles of admon block with labels #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2025
Merged

Fix layout, styles of admon block with labels #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8274263
Fix layout, styles of admon block with labels
recrwplay Apr 30, 2025
6b34d8f
restore border for labeled paragraphs
recrwplay May 1, 2025
c8dbfcb
restore border for labeled paragraphs
recrwplay May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/css/labels.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ div.labels {
flex-wrap: wrap;
}

.admonitionblock > div.labels {
padding: 1rem 1rem 0.75rem;
.admonitionblock div.labels {
padding: 0.5rem 0 1rem;
}

.header-label-container > div.labels {
Expand Down Expand Up @@ -62,16 +62,16 @@ h1 > .header-label {
margin-bottom: 0.2rem;
}

.has-label {
.paragraph.has-label {
padding-left: 0.4rem;
border-left: 2px solid rgba(var(--colors-baltic-60));
}

.has-label:has(> .labels > .label--new) {
.paragraph.has-label:has(> .labels > .label--new) {
border-left-color: var(--success-color);
}

.has-label:has(> .labels > .label--deprecated) {
.paragraph.has-label:has(> .labels > .label--deprecated) {
border-left-color: var(--deprecated-color);
}

Expand Down
8 changes: 7 additions & 1 deletion src/js/60-docs-roles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ document.addEventListener('DOMContentLoaded', function () {
// no need to do anything if we found only undefined roles
if (labels.length === 0) return

const labelsLocation = (roleDiv.firstElementChild && headings.includes(roleDiv.firstElementChild.nodeName)) ? roleDiv.firstElementChild : roleDiv
let labelsLocation = (roleDiv.firstElementChild && headings.includes(roleDiv.firstElementChild.nodeName)) ? roleDiv.firstElementChild : roleDiv
const labelsDiv = createElement('div', 'labels')

for (const label of labels) {
Expand All @@ -154,6 +154,12 @@ document.addEventListener('DOMContentLoaded', function () {
}
}

console.log(roleDiv.classList)

if (roleDiv.classList.contains('admonitionblock')) {
labelsLocation = roleDiv.querySelector('td.content')
}

if (roleDiv.nodeName === 'H1' || headings.includes(roleDiv.firstElementChild.nodeName)) {
labelsLocation.append(labelsDiv)
labelsLocation.classList.add('header-label-container')
Expand Down