Skip to content

Conversation

@tarun1992
Copy link
Contributor

Fix for issue raised no #88

@nielsdejong
Copy link
Collaborator

hi @tarun1992 ,

Thanks for the contribution! I just posted a comment about this one in the thread here:
#88

I'm thinking to make this config.json field optional, for example:

dispatch(setConnectionProperties(config['standaloneProtocol'], config['standaloneHost'], config['standalonePort'], config['standaloneDatabase'], state.application.connection.username, config['standalonePassword'] ? config['standalonePassword'] : state.application.connection.password));

This way the application will pick up the hardcoded password if specified in config.json, otherwise it will default to state.application.connection.password (the latest in the application cache). What do you think?

@nielsdejong
Copy link
Collaborator

Another thought: we should probably add the same thing for the username here, so that it's in sync.

@tarun1992
Copy link
Contributor Author

That's a very good idea. I really like that.

@nielsdejong nielsdejong changed the base branch from master to develop March 1, 2022 06:51
@nielsdejong nielsdejong changed the base branch from develop to master March 1, 2022 06:51
@nielsdejong
Copy link
Collaborator

Hi @tarun1992 ,
I've made some small changes to this one to pick up the standaloneUsername and standalonePassword fields only if they are specified in the config.json file.

The behaviour is now like this:

  • If standaloneUsername/standalonePassword are not specified (default behaviour), do the same thing as before. The connection modal is presented to the user with all fields prefilled except the username/password.
  • If standaloneUsername/standalonePassword are specified in config.json, pick these up, and automatically make the connection to the database + load the dashboard. The connection screen is skipped in its entirety.

Best,
Niels

@nielsdejong nielsdejong merged commit 6c84da1 into neo4j-labs:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants