This repository was archived by the owner on Jul 6, 2023. It is now read-only.
Addded streaming results from the driver #108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* both table mode and plain mode will now NOT materialize all results anymore but stream to output * table mode samples the first 100 rows for total width * fields that are longer are wrapped, disable with --wrap false * added --width to specify table width * tested with PanamaPapers dataset, that caused an OOM before, now finishes quickly * improved table format implementation for performance
spacecowboy
reviewed
Jan 30, 2018
| .dest("force-non-interactive") | ||
| .action(new StoreTrueArgumentAction()); | ||
|
|
||
| parser.addArgument("--width") |
Contributor
There was a problem hiding this comment.
Deeply disagree with this design decision. The program should output a sensible width automatically
There was a problem hiding this comment.
neo4j-client has a similar option, :set width=??? (a cli option, allowing width changes at runtime, rather than a command line switch). It also accepts :set width=auto, which checks the terminal window size and sets the size based on that (auto is the default). Assuming Java supports finding the termwidth, perhaps a width option (with default) is a neat solution here too?
Contributor
There was a problem hiding this comment.
well if I were designing this, I'd have a single switch: --wrap[=[false|true|INT]] where true would be some kind of automatic width (or sensible value).
pontusmelke
reviewed
Jan 17, 2019
| .append("\nPlease specify --username, and optionally --password, as argument(s)") | ||
| .append("\nor as environment variable(s), NEO4J_USERNAME, and NEO4J_PASSWORD respectively.") | ||
| .append("\nSee --help for more info."); | ||
| .append("\nPlease specify --username, and optionally --password, as argument(s)") |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
but stream to output