This repository was archived by the owner on Jul 6, 2023. It is now read-only.
Don't send parameter lambdas to server #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fickludd
suggested changes
Mar 22, 2019
Contributor
fickludd
left a comment
fickludd
left a comment
There was a problem hiding this comment.
This is great, but we should think about if we can change to a non-SNAPSHOT dependency.
build.gradle
Outdated
|
|
||
| argparse4jVersion = '0.7.0' | ||
| junitVersion = '4.12' | ||
| evaluatorVersion = '4.0.0-SNAPSHOT' |
Contributor
There was a problem hiding this comment.
Won't this be a problem? Neo4j 4.0.0-SNAPSHOT is not on maven central, so how is anyone going to build cypher-shell now, without building some local snapshot of Neo4j?
It would be great if we could get a release of the evaluator somehow.
Collaborator
Author
There was a problem hiding this comment.
yes we will have to figure that out. This PR is mostly to check the integration with the evaluator.
Contributor
|
I backported the expression evaluator to 3.5, and retargeted this do depend on the expression evaluator from 3.5.4, which will be available as soon as that patch is released. |
fickludd
approved these changes
Mar 27, 2019
For evaluating parameters we were basically sending `RETURN expression` in order to evaluate the expression. This PR replaces that with using a new shiny stand-alone expression evaluator.
Member
|
3.5.4 is out :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For evaluating parameters we were basically sending
RETURN expressionin order to evaluate the expression. This PR replaces that with using a
new shiny stand-alone expression evaluator.
[changelog]: Parameters are now evaluated client-side instead of being passed to the server. This greatly improves speed of parameter evauation.