This repository was archived by the owner on Jul 6, 2023. It is now read-only.
Update to Java Driver 4.0.0-betaXX #171
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I pulled the first commit into #172 |
henriknyman
suggested changes
Oct 11, 2019
| public interface DatabaseManager | ||
| { | ||
| String ABSENT_DB_NAME = ""; | ||
| String ABSENT_DB_NAME = "neo4j"; // TODO After beta02, "" and literal null are no longer valid database names. |
Collaborator
There was a problem hiding this comment.
This will break the internal Cypher Shell logic of distinguishing between having the database name set to an explicit name and having it set to whatever is the default.
We have already adapted to never pass the empty string to the driver a long time ago (See BoltStateHandler.reconnect()).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 2 commits.
The first one updates to 4.0.0-beta02, mainly fixing package names and imports, but also
BookmarkapiThe 2nd one updates to the current driver snapshot and is kinda bigger change.
The latest driver doesn't support
nullor the empty string as database name and doesn't have a constant ofABSENT_DB_NAME. I set this fix toneo4j, as I didn't want to mess with the logic cypher shell has in place.Feel. free to pick any commit or both, but please be aware that this is currently untested. I compiled my fork and actually used it, but didn't run the test.