Fix getting server version and database name on failure #178
Conversation
When the ping query fails, e.g. on credentials expired exception, we still need to get the server version. - Add handling of empty version string
pontusmelke
left a comment
pontusmelke
left a comment
There was a problem hiding this comment.
The fix is fine, I don't understand why we throw the first time though?
| try { | ||
| summary = run.consume(); | ||
| } finally { | ||
| // Since run.consume() can throw the first time we have to go through this extra hoop to get the summary |
There was a problem hiding this comment.
Why? Is this known/documented behavior?
There was a problem hiding this comment.
Hmm, it throws because it is not authorized to execute the ping query when password change is required in 4.0 anymore. It just started happening when packaged with the very latest Neo4j, but I wonder wether this really changed that recently. Maybe the neo4j docker image that is used to run integration tests is too far behind or there is some problem with the Team City test config parameters for 4.0.
There was a problem hiding this comment.
@pontusmelke Ideally we want to get the version and database name by the simplest possible Bolt message or command that is always allowed to run (at least if authenticated), instead of having to execute an actual query, but this should do until we get Neo4j server support and/or driver support.
2 participants
When the ping query fails, e.g. on credentials expired exception,
we still need to get the server version.