This repository was archived by the owner on Jul 6, 2023. It is now read-only.
Fix connection when default database is unavailable #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henriknyman
force-pushed
the
4.0-fix-connection-when-no-default-database
branch
from
2bbc861 to
b3e0447
Compare
pontusmelke
approved these changes
Dec 3, 2019
| boltStateHandler.disconnect(); | ||
| } | ||
|
|
||
| private String getErrorCode(Neo4jException e) { |
Collaborator
There was a problem hiding this comment.
This feels a little brittle but I don't have a better idea.
We should be able to connect to another database or system database even when the default database is stopped. So we no longer use the Java driver verifyConnectivity() method since that is hard-wired to check connectivity toward the default database only. Also adapt to that the DatabaseUnavailable error message could be masked by the driver. Treat any ServiceUnavailable the same in interactive mode.
It will become possible to get the cause of ServiceUnavailableExceptions.
henriknyman
force-pushed
the
4.0-fix-connection-when-no-default-database
branch
from
8b1b71d to
2732f2f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be able to connect to another database or system database
even when the default database is stopped.
So we no longer use the Java driver verifyConnectivity() method
since that is hard-wired to check connectivity toward the default
database only.
Also adapt to that the DatabaseUnavailable error message could be
masked by the driver. Treat any ServiceUnavailable the same in
interactive mode.