This repository was archived by the owner on Jul 6, 2023. It is now read-only.
Fix bug when running non-interactively and password change required #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the situation when running non-interactively without when a password change was required, such as running the following on a vanilla db ``` cypher-shell -u neo4j -p neo4j "RETURN 1" ``` the user was first prompted for a password but then failed with the error >This procedure is no longer available, use: 'ALTER CURRENT USER SET PASSWORD' This was due to a recent change how we handle interactive commands, what happens is we never run the `ping` so we never get a chance to set the `version` field in `BoltStateHandler` which in turn messes up the updating of the password since it thinks we are communicating with an older db.
sherfert
reviewed
Apr 7, 2020
Collaborator
sherfert
left a comment
sherfert
left a comment
There was a problem hiding this comment.
Is it possible to recreate the previously failing case in an integration test?
Collaborator
Author
|
@sherfert There was an integration test that attempted to test this very thing but the test wasn't setting the |
sherfert
approved these changes
Apr 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the situation when running non-interactively without when a password change
was required, such as running the following on a vanilla db
the user was first prompted for a password but then failed with the error
This was due to a recent change how we handle interactive commands, what happens
is we never run the
pingso we never get a chance to set theversionfieldin
BoltStateHandlerwhich in turn messes up the updating of the password sinceit thinks we are communicating with an older db.