This repository was archived by the owner on Jul 6, 2023. It is now read-only.
Fix issues with non-interactive mode prompting for new passwords #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of checks are done if stdin is connected to a tty and somewhere in the mess of logic a check doesn't work properly (at least on Linux) when using --non-interactive via a shell. For instance, if the user account requires a password being changed, it still prompts the user. This checks the cli arg first before bothering to check the System.console() / isatty() results. This trickles down to checks again during the initial exception handling AuthenticationException or Neo4jException handling.
pontusmelke
suggested changes
Sep 3, 2020
Collaborator
pontusmelke
left a comment
pontusmelke
left a comment
There was a problem hiding this comment.
@voutilad Thanks for the PR and forgive me for dropping the ball here a little bit, I should have got to this PR earlier. I think we can't change the default behaviour where if you run a script and needs to change password you get prompted since that is the behavior we've had since 4.0. However I agree that when using --non-interactive this behavior should be overridden. I made an attempt at that here, #249.
So either apply that last commit here or I can push it to your branch but then you must whitelist me as a contributor to your fork.
Contributor
Author
|
@pontusmelke just incorporated your commit. |
Collaborator
|
@voutilad thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that if a 4.0/4.1 user had their account set to requiring a password change (for instance, after a fresh install), cypher-shell would still prompt for the new password when using
--non-interactive.This prevents safe usage via shell scripts, Ansible, etc. that will never send a newline to stdin causing the cypher-shell program to never exit.