Editorial review of access control index.adoc + matching formatting #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for neo4j-docs-cypher ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
lidiazuin
changed the title
lidiazuin
added
cherry-pick-this-to-4.4
martin-neotech
suggested changes
Jul 26, 2022
Comment on lines
+30
to
+34
| Almost all administration commands have variations. | ||
| The most common are parts of the command that are optional or that can have multiple values. | ||
|
|
||
| The special characters and their meaning are as follows: | ||
| See below a summary of the syntax to check all versions of a command. | ||
| These summaries use some special characters to indicate such variations. |
Contributor
There was a problem hiding this comment.
Dont change this for now. It needs rewording in the future.
The sentence on line 32, 33, and 35 talks about Cypher syntax style.
And the above is about variations of administration commands.
NOTE: I would just create a card for the future about this exact part and not change it in this PR.
Contributor
Author
There was a problem hiding this comment.
Do you mean reverting all suggestions and keeping the original as it was?
Parts of the command that are optional or can have multiple values are most common.
To show all versions of a command, a summary of the syntax will be presented.
These summaries will use some special characters to indicate such variations.
The special characters and their meaning are as follows:
Co-authored-by: Martin <martin.bendsoe@neotechnology.com>
Co-authored-by: Martin <martin.bendsoe@neotechnology.com>
Co-authored-by: Martin <martin.bendsoe@neotechnology.com>
Co-authored-by: Martin <martin.bendsoe@neotechnology.com>
Co-authored-by: Martin <martin.bendsoe@neotechnology.com>
lidiazuin
commented
Jul 27, 2022
Contributor
Author
lidiazuin
left a comment
lidiazuin
left a comment
There was a problem hiding this comment.
Thanks for the review, Martin. I left only a few questions and suggestions.
Comment on lines
+30
to
+34
| Almost all administration commands have variations. | ||
| The most common are parts of the command that are optional or that can have multiple values. | ||
|
|
||
| The special characters and their meaning are as follows: | ||
| See below a summary of the syntax to check all versions of a command. | ||
| These summaries use some special characters to indicate such variations. |
Contributor
Author
There was a problem hiding this comment.
Do you mean reverting all suggestions and keeping the original as it was?
Parts of the command that are optional or can have multiple values are most common.
To show all versions of a command, a summary of the syntax will be presented.
These summaries will use some special characters to indicate such variations.
The special characters and their meaning are as follows:
Merged
lidiazuin
added a commit
that referenced
this pull request
Oct 10, 2022
) (#149) * merging editorial review and matching formatting * more fixes * Update modules/ROOT/pages/access-control/index.adoc Co-authored-by: Martin <martin.bendsoe@neotechnology.com> * Update modules/ROOT/pages/access-control/index.adoc Co-authored-by: Martin <martin.bendsoe@neotechnology.com> * Update modules/ROOT/pages/access-control/index.adoc Co-authored-by: Martin <martin.bendsoe@neotechnology.com> * Update modules/ROOT/pages/access-control/index.adoc Co-authored-by: Martin <martin.bendsoe@neotechnology.com> * Update modules/ROOT/pages/access-control/index.adoc Co-authored-by: Martin <martin.bendsoe@neotechnology.com> * Update modules/ROOT/pages/access-control/index.adoc * Update modules/ROOT/pages/access-control/index.adoc Co-authored-by: Martin <martin.bendsoe@neotechnology.com> Co-authored-by: Martin <martin.bendsoe@neotechnology.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this https://github.com/neo-technology/neo4j-manual-modeling/pull/2880