updating query plan for operator.adoc #395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you've updated the documentation! Check out your changes at https://neo4j-docs-cypher-395.surge.sh |
…r into fix-operator-plan
xiaojieyang
added
the
cherry-pick-this-to-5.x
xiaojieyang
commented
Feb 9, 2023
There was a problem hiding this comment.
change Query into:
PROFILE
MATCH (bob:Person {name: 'Bob'})-[:WORKS_IN]->(loc)<-[:WORKS_IN]-(matt:Person {name: 'Mattias'}) USING JOIN ON loc
RETURN loc.name
remove noplay roles
|
One last query plan due to a change happened in January, where |
stefano-ottolenghi
approved these changes
Feb 9, 2023
stefano-ottolenghi
added a commit
that referenced
this pull request
Feb 10, 2023
JPryce-Aklundh
pushed a commit
that referenced
this pull request
Apr 13, 2023
To a good extent, this is a rollback of #395. This investigation started with the query plan of `CacheProperties` being wrong since... well, there was no `CacheProperties` operator in the plan. The testing was happy that way, which was odd. It turned out that it was because of the example query in the `Eager` operator, which effectively _cleared_ the database, so that all examples afterwards ran on an empty db. `CacheProperties` comes after `Eager` in the operators page, so that the `CacheProperties` example ran on an empty db. Summary of changes: - Changed `Eager` example so that it deletes only _two_ nodes, rather than _all_ nodes. The query plan is essentially unchanged, other than indexes being used. Most notably, `Eager` is still triggered, presumably as the db doesn't know upfront how many nodes have that property value anyway. - Fixing the above triggered a bunch of failures (for `CacheProperties`, `EagerAggregation`, `Distinct`) , which are essentially the plans changed in #395. I've restored them as they were before, but not altered them otherwise. - Given proper names to indexes/constraints, describing what they _index_ rather than what they _test_. - Moved the setup queries _inside_ the sections they belong to, rather than _before_ the respective openings. - Removed a setup block that dropped and recreated the exact same index. - The `Delete` example was acting on `(me:Person {name: 'me'})`, which has relationships attached to it, so an error is raised. Or rather, no failure used to happen because, previously, the `Eager` example cleared the whole db, so `DELETE me` was deleting a non-existent node, and now the `Eager` example `DETACH DELETE`s the `me` node, so that it keeps not existing. However, if for whatever reason we changed some of the examples involved and it turned out that `me` existed with relationships (as the page setup creates), then we'd get a failure. So I've changed the `DELETE` example to act on `you`, rather than `me`, as `you` never exists. There's also some perverse joy involved with pretending to obliterate the reader, so I like it better.
JPryce-Aklundh
pushed a commit
to JPryce-Aklundh/docs-cypher
that referenced
this pull request
Apr 13, 2023
To a good extent, this is a rollback of neo4j#395. This investigation started with the query plan of `CacheProperties` being wrong since... well, there was no `CacheProperties` operator in the plan. The testing was happy that way, which was odd. It turned out that it was because of the example query in the `Eager` operator, which effectively _cleared_ the database, so that all examples afterwards ran on an empty db. `CacheProperties` comes after `Eager` in the operators page, so that the `CacheProperties` example ran on an empty db. Summary of changes: - Changed `Eager` example so that it deletes only _two_ nodes, rather than _all_ nodes. The query plan is essentially unchanged, other than indexes being used. Most notably, `Eager` is still triggered, presumably as the db doesn't know upfront how many nodes have that property value anyway. - Fixing the above triggered a bunch of failures (for `CacheProperties`, `EagerAggregation`, `Distinct`) , which are essentially the plans changed in neo4j#395. I've restored them as they were before, but not altered them otherwise. - Given proper names to indexes/constraints, describing what they _index_ rather than what they _test_. - Moved the setup queries _inside_ the sections they belong to, rather than _before_ the respective openings. - Removed a setup block that dropped and recreated the exact same index. - The `Delete` example was acting on `(me:Person {name: 'me'})`, which has relationships attached to it, so an error is raised. Or rather, no failure used to happen because, previously, the `Eager` example cleared the whole db, so `DELETE me` was deleting a non-existent node, and now the `Eager` example `DETACH DELETE`s the `me` node, so that it keeps not existing. However, if for whatever reason we changed some of the examples involved and it turned out that `me` existed with relationships (as the page setup creates), then we'd get a failure. So I've changed the `DELETE` example to act on `you`, rather than `me`, as `you` never exists. There's also some perverse joy involved with pretending to obliterate the reader, so I like it better.
lidiazuin
pushed a commit
to lidiazuin/docs-cypher
that referenced
this pull request
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.