5.0 remove drop constraint by schema #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hunterness
requested changes
Jul 20, 2022
Collaborator
There was a problem hiding this comment.
You are missing updates in https://github.com/neo4j/docs-cypher/blob/74533af7b1d94ccf16a8d2c5c55496c5c4d52ffb/modules/ROOT/pages/constraints/syntax.adoc
And the deprecations/additions/removal section which I assume is the TODO in the description
✅ Deploy Preview for neo4j-docs-cypher ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
martin-neotech
added
the
removed
Hunterness
reviewed
Jul 22, 2022
| label:removed[] | ||
| [source, cypher, role="noheader", indent=0] | ||
| ---- | ||
| DROP CONSTRAINT ON (n:Label) ASSERT (n.prop) IS NODE KEY |
Collaborator
There was a problem hiding this comment.
In the version we added before, we had all drop command in one place:
a|
label:functionality[]
label:removed[]
[source, cypher, role="noheader"]
----
DROP CONSTRAINT ON (n:Label) ASSERT (n.prop) IS NODE KEY
----
[source, cypher, role="noheader"]
----
DROP CONSTRAINT ON (n:Label) ASSERT (n.prop) IS UNIQUE
----
[source, cypher, role="noheader"]
----
DROP CONSTRAINT ON (n:Label) ASSERT exists(n.prop)
----
[source, cypher, role="noheader"]
----
DROP CONSTRAINT ON ()-[r:Type]-() ASSERT exists(r.prop)
----
a|
Replaced by:
[source, cypher, role="noheader"]
----
DROP CONSTRAINT name
----
so instead of having 4 entries we had one, cause it's the same functionality that has been removed
a|
label:functionality[]
label:removed[]
[source, cypher, role="noheader"]
----
DROP CONSTRAINT ON (n:Label) ASSERT (n.prop) IS NODE KEY
----
[source, cypher, role="noheader"]
----
DROP CONSTRAINT ON (n:Label) ASSERT (n.prop) IS UNIQUE
----
[source, cypher, role="noheader"]
----
DROP CONSTRAINT ON (n:Label) ASSERT exists(n.prop)
----
[source, cypher, role="noheader"]
----
DROP CONSTRAINT ON ()-[r:Type]-() ASSERT exists(r.prop)
----
a|
The ability to dropp a constraint based on the schema has been removed.
Use the command to drop a constraint by the name of the constraint instead, `DROP CONSTRAINT constraint_name`.
----
|
|
||
| [discrete] | ||
| [[administration-constraints-drop-a-unique-constraint]] | ||
| === Drop a unique constraint |
Collaborator
There was a problem hiding this comment.
I still think you're missing removing things in the .../constraints/syntax.adoc file
Contributor
Author
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntax
DROP CONSTRAINT ON ...has been removed in Neo4j 5.0.PR for
DROP INDEX ONwas merged in #7