-
Notifications
You must be signed in to change notification settings - Fork 64
5.0 remove drop constraint by schema #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
martin-neotech
merged 4 commits into
neo4j:dev
from
martin-neotech:5.0-remove-drop-constraint-by-schema
Jul 21, 2022
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,8 +35,59 @@ The ability to dropp an index based on the schema has been removed. | |
|
|
||
| Use the command to drop an index by the name of the index instead, `DROP INDEX index_name`. | ||
|
|
||
| |=== | ||
|
|
||
| a| | ||
| label:functionality[] | ||
| label:removed[] | ||
| [source, cypher, role="noheader", indent=0] | ||
| ---- | ||
| DROP CONSTRAINT ON (n:Label) ASSERT (n.prop) IS NODE KEY | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the version we added before, we had all drop command in one place: so instead of having 4 entries we had one, cause it's the same functionality that has been removed |
||
| ---- | ||
| a| | ||
| The ability to dropp a constraint based on the schema has been removed. | ||
|
|
||
| Use the command to drop a constraint by the name of the constraint instead, `DROP CONSTRAINT constraint_name`. | ||
|
|
||
|
|
||
| a| | ||
| label:functionality[] | ||
| label:removed[] | ||
| [source, cypher, role="noheader", indent=0] | ||
| ---- | ||
| DROP CONSTRAINT ON (n:Label) ASSERT (n.prop) IS UNIQUE | ||
| ---- | ||
| a| | ||
| The ability to dropp a constraint based on the schema has been removed. | ||
|
|
||
| Use the command to drop a constraint by the name of the constraint instead, `DROP CONSTRAINT constraint_name`. | ||
|
|
||
|
|
||
| a| | ||
| label:functionality[] | ||
| label:removed[] | ||
| [source, cypher, role="noheader", indent=0] | ||
| ---- | ||
| DROP CONSTRAINT ON (n:Label) ASSERT exists(n.prop) | ||
| ---- | ||
| a| | ||
| The ability to dropp a constraint based on the schema has been removed. | ||
|
|
||
| Use the command to drop a constraint by the name of the constraint instead, `DROP CONSTRAINT constraint_name`. | ||
|
|
||
|
|
||
| a| | ||
| label:functionality[] | ||
| label:removed[] | ||
| [source, cypher, role="noheader", indent=0] | ||
| ---- | ||
| DROP CONSTRAINT ON ()-[r:Type]-() ASSERT exists(r.prop) | ||
| ---- | ||
| a| | ||
| The ability to dropp a constraint based on the schema has been removed. | ||
|
|
||
| Use the command to drop a constraint by the name of the constraint instead, `DROP CONSTRAINT constraint_name`. | ||
|
|
||
| |=== | ||
|
|
||
| // === Deprecated features | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think you're missing removing things in the
.../constraints/syntax.adocfileThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hunterness #16