Missing and broken aliases in 5.x #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjfwebb
approved these changes
Mar 18, 2024
lidiazuin
reviewed
Mar 18, 2024
Contributor
lidiazuin
left a comment
lidiazuin
left a comment
There was a problem hiding this comment.
Thanks a lot! Left some comments
| [[ogm-installation]] | ||
| :description: This page describes how to install the OGM in Neo4j GraphQL and includes examples of how to use it. | ||
| = Installation | ||
| :page-aliases: ogm/examples/index.adoc, omg/examples/rest-api.adoc, omg/examples/custom-resolvers.adoc |
Contributor
There was a problem hiding this comment.
https://neo4j.com/docs/graphql/3/ogm/examples/custom-resolvers/ is already listed in the three versions and it's taking to https://neo4j.com/docs/graphql/5/custom-resolvers/ . We need to remove it from here or it will cause a loop.
omg/examples/rest-api.adoc doesn't have a substitute, so I wouldn't redirect to /ogm/installation.adoc
All in all, I think we could go only with ogm/examples/index.adoc
Contributor
Author
There was a problem hiding this comment.
true and true, updated
Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.