Skip to content

Conversation

@lidiazuin
Copy link
Contributor

No description provided.

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Aug 15, 2023

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

----
NEO4J_USER=neo4j
NEO4J_PASSWORD=password
NEO4J_URI=neo4j+s://0083654f.databases.neo4j.io
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it fine to add a real DB URI to the documentation? Can we be sure that this won't ever be used by a real user in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the password is not correct so it's the same as using any placeholder username, I think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the password is not correct so it's the same as using any placeholder username, I think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True I just wanted to make sure we weren't exposing a real DB URI unnecessarily, but it is probably OK.


=== Using a Neo4j database

For a database located at "bolt://localhost:7687", with the username "neo4j" and the password "password", add the following to the bottom of your `index.js` file:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be worth noting that the port is configurable in the database so it might be wrong. Or specifying that 7687 is the default but we recommend double checking?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it with a link to the page about ports configuration

Copy link
Contributor

@mjfwebb mjfwebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@lidiazuin lidiazuin merged commit dc1a495 into neo4j:main Aug 15, 2023
@lidiazuin lidiazuin deleted the auradb branch August 15, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants