-
Notifications
You must be signed in to change notification settings - Fork 15
Adds a more step by step guide to Federation #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like you've updated the documentation! Check out your changes at https://neo4j-docs-graphql-9.surge.sh |
lidiazuin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we need the create-project.adoc if considered what we have in getting-started/index.adoc. Please check this PR #8 to make sure it's the same thing so we can make adjustments . Thanks!
modules/ROOT/pages/how-to-guides/integrations/apollo-federation.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/how-to-guides/integrations/apollo-federation.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/how-to-guides/integrations/apollo-federation.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/how-to-guides/integrations/apollo-federation.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/how-to-guides/integrations/apollo-federation.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/how-to-guides/integrations/apollo-federation.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/how-to-guides/integrations/apollo-federation.adoc
Outdated
Show resolved
Hide resolved
lidiazuin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we need the create-project.adoc if considered what we have in getting-started/index.adoc. Please check this PR #8 to make sure it's the same thing so we can make adjustments . Thanks!
My thinking was that creating a project is going to be a fairly common step in many different how-to guides, so we should maybe have a centralised how-to guide on this which all of those other guides can point to. We can't point to the Getting Started guide because it's a much more holistic example, containing steps further than what most guides will need. If we repeat ourselves in various different guides, they are not going to get updated so there will be discrepancies across the docs. That was my thinking anyway! |
Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com>
Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com>
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com>
I've gotten rid of this now to get this PR ready to merge - hopefully this is now less of a controversial PR! |
lidiazuin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I only want to make some changes later on when turning some things into lists :) thanks for your work!
Adds a more step by step guide to Federation. Also adds instructions on how to optimally create a new project.
Fixes some markdown style code blocks.