Skip to content

Conversation

@tonbut
Copy link
Contributor

@tonbut tonbut commented Feb 15, 2023

No description provided.

@netlify
Copy link

netlify bot commented Feb 15, 2023

Deploy Preview for neo4-docs-java-reference ready!

Name Link
🔨 Latest commit b55ddcf
🔍 Latest deploy log https://app.netlify.com/sites/neo4-docs-java-reference/deploys/63ee2cc8d6955e0008971003
😎 Deploy Preview https://deploy-preview-105--neo4-docs-java-reference.netlify.app/java-reference/5/extending-neo4j/project-setup
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tonbut tonbut requested a review from AlexicaWright February 15, 2023 13:19
Copy link
Contributor

@AlexicaWright AlexicaWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small suggestions and a question.

Build a jar file from Maven and place this onto the Neo4j classpath.

The jar must contain a META-INF file to enable discovery of the providers.
This file should the path:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean? Should be on the path?

The jar must contain a META-INF file to enable discovery of the providers.
This file should the path:

[source, none]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know what to put as the source here, please update if there is a better alternative.

Copy link
Contributor

@AlexicaWright AlexicaWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlexicaWright AlexicaWright merged commit cafa1f4 into neo4j:dev Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants