Skip to content

Conversation

@gem-neo4j
Copy link
Contributor

The current code examples don't work out of the box, and are linked to a github repo which don't contain them. Have updated them to represent the code from the github repo better.

@gem-neo4j gem-neo4j added documentation Improvements or additions to documentation dev dev branch 5.x labels Feb 1, 2023
@netlify
Copy link

netlify bot commented Feb 1, 2023

Deploy Preview for neo4-docs-java-reference ready!

Name Link
🔨 Latest commit 69dbbe3
🔍 Latest deploy log https://app.netlify.com/sites/neo4-docs-java-reference/deploys/63da5c346ade1a00098dcbdd
😎 Deploy Preview https://deploy-preview-97--neo4-docs-java-reference.netlify.app/java-reference/5/extending-neo4j/functions
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@renetapopova renetapopova self-requested a review February 1, 2023 11:46
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gem-neo4j !

@gem-neo4j gem-neo4j force-pushed the dev_update_procedure_example_docs branch from 5303b9a to 69dbbe3 Compare February 1, 2023 12:33
@renetapopova renetapopova merged commit 93b1897 into neo4j:dev Feb 1, 2023
renetapopova pushed a commit to renetapopova/docs-java-reference that referenced this pull request Feb 1, 2023
renetapopova added a commit that referenced this pull request Feb 1, 2023
…ate code examples from linked github repo. (#97) (#101)

Co-authored-by: Gem Lamont <106068376+gem-neo4j@users.noreply.github.com>
AlexicaWright added a commit that referenced this pull request Mar 22, 2023
* resolved conflicts

* resolved conflicts

* Update the documentation for procedures and functions to have up to date code examples from linked github repo. (#97) (#101)

Co-authored-by: Gem Lamont <106068376+gem-neo4j@users.noreply.github.com>

* Adding information about the version of junit used in the example (#103) (#106)

* adding information about the version of junit used in the example and note with instructions for users who want to keep using a previous version

* update after review

* removing incorrect extra lines

* adding the information that this can also be applied to neo4j 5 instead of just 4

* Update modules/ROOT/pages/extending-neo4j/procedures.adoc



---------

Co-authored-by: Jessica Wright <49636617+AlexicaWright@users.noreply.github.com>

---------

Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
Co-authored-by: Gem Lamont <106068376+gem-neo4j@users.noreply.github.com>
Co-authored-by: Lidia Zuin <102308961+lidiazuin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.x cherry-pick-this-to-5.x dev dev branch documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants