Skip to content

Correct max label id #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2023
Merged

Correct max label id #1176

merged 1 commit into from
Nov 10, 2023

Conversation

@emmaholmbergohlsson
Copy link
Contributor

@emmaholmbergohlsson emmaholmbergohlsson commented Nov 10, 2023

2^32 labels has never actually been supported,
anything over 2^31 would fail with an integer overflow.

@emmaholmbergohlsson
Correct max label id
e0d471a 
2^32 labels has never actually been supported,
anything over 2^31 would fail with an integer overflow.
@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Nov 10, 2023 •
edited
Loading

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@emmaholmbergohlsson
Copy link
Contributor Author

emmaholmbergohlsson commented Nov 10, 2023

Corresponding code change https://github.com/neo-technology/neo4j/pull/23063

@renetapopova renetapopova self-requested a review November 10, 2023 14:02
renetapopova
renetapopova approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing them, @emmaholmbergohlsson!

@emmaholmbergohlsson
Copy link
Contributor Author

emmaholmbergohlsson commented Nov 10, 2023

No problem. Can I leave merging and cherry-picking to you @renetapopova or should I do something more?

@renetapopova
Copy link
Collaborator

renetapopova commented Nov 10, 2023

No problem. Can I leave merging and cherry-picking to you @renetapopova or should I do something more?

I'll do it.

@renetapopova renetapopova merged commit c6cb50a into neo4j:dev Nov 10, 2023
@renetapopova
Copy link
Collaborator

renetapopova commented Nov 10, 2023

@emmaholmbergohlsson, is this change applicable to 5.15 or to the current version? The docs are currently on 5.13.

@emmaholmbergohlsson
Copy link
Contributor Author

emmaholmbergohlsson commented Nov 10, 2023

@emmaholmbergohlsson, is this change applicable to 5.15 or to the current version? The docs are currently on 5.13.

The real limit has always been 2^31, so it is applicable to current version as well.
My code change just makes it explicit in the code to give a nicer experience to any customers coming up to that limit

renetapopova pushed a commit to renetapopova/docs-operations that referenced this pull request Nov 10, 2023
@emmaholmbergohlsson @renetapopova
Correct max label id (neo4j#1176)
63ec5d8 
2^32 labels has never actually been supported,
anything over 2^31 would fail with an integer overflow.
@renetapopova renetapopova mentioned this pull request Nov 10, 2023
Merged
renetapopova pushed a commit to renetapopova/docs-operations that referenced this pull request Nov 10, 2023
@emmaholmbergohlsson @renetapopova
Correct max label id (neo4j#1176)
d412d87 
2^32 labels has never actually been supported,
anything over 2^31 would fail with an integer overflow.
@renetapopova renetapopova mentioned this pull request Nov 10, 2023
Merged
renetapopova added a commit that referenced this pull request Nov 10, 2023
@renetapopova @emmaholmbergohlsson
Correct max label id (#1176) (#1179)
519dcc7 
2^32 labels has never actually been supported,
anything over 2^31 would fail with an integer overflow.

Cherry-picked from #1176

Co-authored-by: emmaholmbergohlsson <emma.holmberg.ohlsson@neo4j.com>
renetapopova added a commit that referenced this pull request Nov 10, 2023
@renetapopova @emmaholmbergohlsson
Correct max label id (#1176) (#1180)
ab83737 
2^32 labels has never actually been supported,
anything over 2^31 would fail with an integer overflow.
Cherry-picked from #1176

Co-authored-by: emmaholmbergohlsson <emma.holmberg.ohlsson@neo4j.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@renetapopova renetapopova renetapopova approved these changes

Assignees

No one assigned

Labels

cherry-pick-this-to-4.4 cherry-pick-this-to-5.x dev

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emmaholmbergohlsson @neo-technology-commit-status-publisher @renetapopova