add deprecated causal clustering metrics #1423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexicaWright
requested review from
NataliaIvakina,
nick-giles-neo and
renetapopova
Collaborator
|
Looks good! Thank you, @AlexicaWright! I have one suggestion: to move the label |
NataliaIvakina
approved these changes
Feb 12, 2024
Collaborator
Looks good. I think Natalia's comment is reasonable. We don't have labels in the descriptions in the codebase. Better to keep the descriptions clean. |
Collaborator
renetapopova
left a comment
renetapopova
left a comment
There was a problem hiding this comment.
I left my comment inline.
renetapopova
approved these changes
Feb 12, 2024
Collaborator
renetapopova
left a comment
renetapopova
left a comment
There was a problem hiding this comment.
Thanks, @AlexicaWright!
nick-giles-neo
approved these changes
Feb 12, 2024
Collaborator
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
AlexicaWright
added a commit
to AlexicaWright/docs-operations
that referenced
this pull request
Feb 13, 2024
AlexicaWright
added a commit
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.