Skip to content

Add missing metric <prefix>.transaction.validation_failure #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 18, 2024
Merged

Add missing metric <prefix>.transaction.validation_failure #1544

merged 3 commits into from
Apr 18, 2024

Conversation

@renetapopova
Copy link
Collaborator

@renetapopova renetapopova commented Apr 8, 2024

No description provided.

@renetapopova renetapopova changed the title Dev missing metric Add missing metric <prefix>.transaction.validation_failure Apr 8, 2024
@NataliaIvakina
Copy link
Collaborator

NataliaIvakina commented Apr 8, 2024

This metric is related to MVCC, which has not been released yet. On the other side, it's exposed to users, so we can publish it.

@renetapopova
Copy link
Collaborator Author

renetapopova commented Apr 8, 2024

I'm still trying to understand why the test fails with the missing CatchUp Metrics class, even though we have this class.

@NataliaIvakina
Copy link
Collaborator

NataliaIvakina commented Apr 8, 2024 •
edited
Loading

I'm still trying to understand why the test fails with the missing CatchUp Metrics class, even though we have this class.

because of spelling: in the docs - CatchUp metrics VS in the code - CatchUp Metrics

@renetapopova
Copy link
Collaborator Author

renetapopova commented Apr 8, 2024

I'm still trying to understand why the test fails with the missing CatchUp Metrics class, even though we have this class.

because of spelling: in the docs - CatchUp metrics VS in the code - CatchUp Metrics

Capitalization! I saw this but thought, "No, that can't be the case".

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Apr 8, 2024 •
edited
Loading

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@renetapopova renetapopova merged commit 6a373d2 into neo4j:dev Apr 18, 2024
@renetapopova renetapopova deleted the dev-missing-metric branch April 18, 2024 14:49
renetapopova added a commit to renetapopova/docs-operations that referenced this pull request Apr 18, 2024
@renetapopova
Add missing metric <prefix>.transaction.validation_failure (neo4j#1544)
b1b6f8f
@renetapopova renetapopova mentioned this pull request Apr 18, 2024
Merged
renetapopova added a commit that referenced this pull request Apr 18, 2024
@renetapopova
Add missing metric <prefix>.transaction.validation_failure (#1544) (#…
754aa74 
…1559)

Cherry-picked from #1544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NataliaIvakina NataliaIvakina NataliaIvakina approved these changes

Assignees

No one assigned

Labels

cherry-pick-this-to-5.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@renetapopova @NataliaIvakina @neo-technology-commit-status-publisher