Skip to content

Conversation

@jackwaudby
Copy link
Contributor

Also I added .vscode/ to the .gitignore file.

jackwaudby and others added 3 commits June 5, 2024 13:16
Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com>
Copy link
Collaborator

@NataliaIvakina NataliaIvakina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, @jackwaudby!

Co-authored-by: NataliaIvakina <82437520+NataliaIvakina@users.noreply.github.com>
@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Jun 5, 2024

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@jackwaudby
Copy link
Contributor Author

@NataliaIvakina There still seems to be a failing test, I can't work out why. Any ideas? 🤔

@stefano-ottolenghi
Copy link
Contributor

stefano-ottolenghi commented Jun 10, 2024

@jackwaudby The test failed because when it ran the changes in neo4j had not been merged (or built) yet. I re-ran the tests now and it's all right.

@jackwaudby
Copy link
Contributor Author

Excellent @stefano-ottolenghi thanks - I shall hit the merge button!

@jackwaudby jackwaudby merged commit a89a356 into neo4j:dev Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants