Added support for generic s3 endpoints #2066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renetapopova
approved these changes
Jan 23, 2025
Collaborator
renetapopova
left a comment
renetapopova
left a comment
There was a problem hiding this comment.
Thanks, @bfeshti. I pushed some minor editorial things.
Collaborator
|
Actually, I decided to play around with the example configurations. @bfeshti, could you please take a look at the preview to see if it works for you? Thanks! |
Collaborator
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
renetapopova
added a commit
that referenced
this pull request
Jan 23, 2025
Cherry-picked from #2066 --------- Co-authored-by: Bledi Feshti <bledifeshti@neotechnology.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for generic s3 endpoints and deprecate MinIO specific config